Merge pull request #95 from crux-bphc/add-warning-check-for-publishing

Check if warnings exist before publishing a draft tt
crux-bphc · Dec 29, 2023 · 4d8b970 · 4d8b970
2 parents 84c777e + 91ae517
commit 4d8b970
Showing 1 changed file with 11 additions and 2 deletions.
diff --git a/backend/src/controllers/timetable/editTimetableMetadata.ts b/backend/src/controllers/timetable/editTimetableMetadata.ts
@@ -73,6 +73,10 @@ export const editTimetableMetadata = async (req: Request, res: Response) => {
     return res.status(404).json({ message: "timetable not found" });
   }
 
+  if (timetable.authorId !== author.id) {
+    return res.status(403).json({ message: "user does not own timetable" });
+  }
+
   if (
     timetable.draft &&
     timetable.sections.length === 0 &&
@@ -83,8 +87,13 @@ export const editTimetableMetadata = async (req: Request, res: Response) => {
     });
   }
 
-  if (timetable.authorId !== author.id) {
-    return res.status(403).json({ message: "user does not own timetable" });
+  if (
+    timetable.warnings.length > 0 &&
+    (isDraft === false || isPrivate === false)
+  ) {
+    return res.status(400).json({
+      message: "cannot publish timetable with warnings",
+    });
   }
 
   try {