Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dockerize] Fix crust env dockerfile #319

Merged
merged 1 commit into from
Nov 17, 2020
Merged

[Dockerize] Fix crust env dockerfile #319

merged 1 commit into from
Nov 17, 2020

Conversation

badkk
Copy link
Contributor

@badkk badkk commented Nov 17, 2020

Update reasons

  1. Since we import ring library which depends on llvm 10.0(latest llvm contains linker bug, details)
  2. However, we also depends on released stable substrate, which can only build-passed based on BEFORE nightly-2020-10-06 and AFTER nightly-2020-07-10.
  3. So we picked nightly-2020-08-10 as our base image

@badkk badkk added A4-enhancement PR for refactor, better api or improve performance I2-bug 🐜 The client fails to follow expected behavior. labels Nov 17, 2020
@badkk badkk added the need-cherry-block🍒 Need cherry pick this commit to release branch label Nov 17, 2020
@badkk
Copy link
Contributor Author

badkk commented Nov 17, 2020

Need cherry pick to release/0.10.0 and release/0.10.1

badkk
badkk commented Nov 17, 2020
View reviewed changes
docker/crust-env/Dockerfile
RUN apt-get -y install lsb-release wget software-properties-common
RUN wget https://apt.llvm.org/llvm.sh
RUN chmod +x llvm.sh
RUN ./llvm.sh 10
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

installing llvm should before rustup nightly toolchain installing

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fucking stupid sheeeet💩

@badkk badkk merged commit 5a7ee0f into master Nov 17, 2020
@badkk badkk deleted the zikun/fix-docker-env branch November 17, 2020 14:32
badkk added a commit that referenced this pull request Nov 26, 2020
@badkk
Fix crust env (#319)
3b34eb2
@mmyyrroonn mmyyrroonn removed the need-cherry-block🍒 Need cherry pick this commit to release branch label Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmyyrroonn mmyyrroonn mmyyrroonn approved these changes

@TonyCode2012 TonyCode2012 Awaiting requested review from TonyCode2012

@LowEntropyBody LowEntropyBody Awaiting requested review from LowEntropyBody

Assignees
No one assigned
Labels
A4-enhancement PR for refactor, better api or improve performance I2-bug 🐜 The client fails to follow expected behavior.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@badkk @mmyyrroonn