Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Basic decision engine(II) #5

Merged
merged 3 commits into from
Nov 7, 2020
Merged

Basic decision engine(II) #5

merged 3 commits into from
Nov 7, 2020

Conversation

badkk
Copy link
Contributor

@badkk badkk commented Nov 7, 2020

  1. Add pending, pulling and sealing base function logic;
  2. Add pending/pulling/sealing subscriber(listener);
  3. Add basic index.js main logic

@badkk badkk changed the title Add pending pickup Basic decision engine(II) Nov 7, 2020
@badkk
Copy link
Contributor Author

badkk commented Nov 7, 2020

Later job with #4

@badkk badkk merged commit ad497db into main Nov 7, 2020
@badkk badkk deleted the zikun/add-pending-pickup branch November 7, 2020 09:26
badkk
badkk commented Nov 7, 2020
View reviewed changes
src/decision/index.ts
if (newSorder) {
const nt: Task = {
cid: newSorder.file_identifier,
bn: bn,
size: parseInt(newSorder.file_size),
size: _.parseInt(newSorder.file_size, 10),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change here @pangwa

badkk
badkk commented Nov 7, 2020
View reviewed changes
src/decision/index.ts

for (const pt of oldPts) {
// 2. If join pullings and start puling in ipfs, otherwise push back to pending tasks
if (await this.pickOrDropPending(pt.cid, pt.size)) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add await here @pangwa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmyyrroonn mmyyrroonn mmyyrroonn approved these changes

@pangwa pangwa Awaiting requested review from pangwa

@TonyCode2012 TonyCode2012 Awaiting requested review from TonyCode2012

@LowEntropyBody LowEntropyBody Awaiting requested review from LowEntropyBody

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@badkk @mmyyrroonn