Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VEX-7861: Port previous fixes to current code #41

Merged
merged 1 commit into from
Sep 29, 2022

Conversation

gabriel-rivero
Copy link

@gabriel-rivero gabriel-rivero commented Sep 27, 2022

This PR ports previous fixes to the latest react-native-video

Jira: VEX-7861

Velocity PR: https://github.com/crunchyroll/velocity/pull/2680

Previous improvements were not merged to the upstream and were lost when we upgraded the version, this PR ports the fixes to the current code.
Specifically, the fixes are, to disable backbuffer when free memory is too low, and restrict the maximum video quality based on the device's capabilities

Reviews

PR Checklist

  • [/] Unit tests have been written
  • [/] Documentation has been created and/or updated

Testing instructions

Android mobile

Test harness: https://static.cx-staging.com/vilos-v2-qa/task/VEX-7861-re-enable-backbuffer/android-mobile/android-app-debug.apk

Client app: https://static.cx-staging.com/vilos-v2-qa/task/VEX-7861-re-enable-backbuffer/androidmobile-client/etp-android-debug.apk

Android mobile phone
1. execute yarn start-androidmobile-client --clean
2. play any video at the beginning of a series
3. tap on next video
4. confirm the video plays as usual

@gabriel-rivero gabriel-rivero merged commit ddca85d into release/6.X Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant