Added Environment variables propagation and mapping feature from ARGOCD_ENV_{VARIABLE} to {VARIABLE}

[kikokikok]

No description provided.

[kikokikok]

fixes #607

[kikokikok]

First implementation to validate the concept.
Should I gate it with a new LOVELY_ENV_PROPAGATION_ENABLED and LOVELY_ENV_PROPAGATION_FILTER environment variables ?

[Joibel]

I don't think what you've done here will work as you're expecting.

cmd.Env is not currently set by the existing code, so it would pick up environment variables from the processes environment. Those specified in the application object do NOT get transferred to cmp plugins as is, so the ones you've written in your original issue won't be present - or else they would just work out of the box without your code change. The ones you put in the application get transferred, but they get prefixed with ARGOCD_ENV_ which you're not stripping anywhere.

What I'd have probably implemented is a new parameter (which you weirdly can specify through environment variables) to transfer a bunch of KEY=value environment variables in. I haven't thought this through fully.

[kikokikok]

Oh I am not done at all ! I am going through a refactoring to have the Generate method take multiple optional GenerateOption instances, same with the Execute part.
I'm added two Lovely features, one bool to enable env propagation and another with the prefix based filtering of the env variables to propagate. Making it available to all processors and extensible through the GenerateOption and ExecuteOption struct.

[kikokikok]

BTW just understood your comment, I finished the refactoring I wanted to introduce so that you guys have an extensibility mechanism for later using GenerateOptions and ExecuteOptions

• Will now use it to implement the missing piece. Prefix mapper from ARGO_ENV_ to injected ENV if I understood you correctly.

[kikokikok]

@Joibel I think it should be fine now. I have drastically simplified my approach after getting to know a bit better your code base.
Introduced the Env variables mapping as a feature with LOVELY_ENV_PROPAGATION
And added a test for helmfile to test proper mapping from ARGOCD_ENV_ prefixed env to expected one.
Tested the plugin locally in my argocd setup with my Application, it works as expected

[github-actions]

GoGitOps Review

Grade: A+ (100.0%)

Files: 21

Issues: 0

gofmt: 100%

go_vet: 100%

gocyclo: 100%

golint: 100%

ineffassign: 100%

license: 100%

misspell: 100%

This report was generated using GoGitOps.

[kikokikok]

Hello @Joibel,

Anything you'd like me to change in the PR, let me know. I tried to minimize the impact as much as possible.
Thanks !

[Joibel]

Hello @Joibel,

Anything you'd like me to change in the PR, let me know. I tried to minimize the impact as much as possible. Thanks !

Nothing at the moment, I haven't had a chance to look over the PR yet. It's the week before kubecon, which means I'm quite busy, but I will take a look when I get a chance.

[Joibel]

LGTM, thank you for doing this

[Joibel]

I am releasing 1.2.0 with this in.