Add sound effect #14
Open
Add sound effect #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GreatWizard
force-pushed
the
feat/sound-effect
branch
from
420bf92 to
b9f0e51
Compare
|
Just tried it. Working but sound sample is bit harsh, sounds like typewriter. |
GreatWizard
force-pushed
the
feat/sound-effect
branch
2 times, most recently
from
7b7346c to
4f39f37
Compare
GreatWizard
force-pushed
the
feat/sound-effect
branch
from
4f39f37 to
8058db9
Compare
|
I agree, works well, but this sound is a bit too much like a typewriter. Also, I don't think sounds should be added without a mute option. @GreatWizard I'm going to take a deeper look at this soon but I think there should be a solution here that is a little more robust that possibly uses a config file to define a sound "profile" for a switch type that maybe defines different sounds for mods and allows some variation. |
|
About the mute option. It's already a feature in browsers, all users can mute a tab when audio are detected by the browser |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #9
Feature
Add sound effect (#14)
I add a simple audio tag with a
switch.mp3sound next to the canvas-wrapper.Then I made a SoundUtil in order to play it many times and calls the SoundUtil in the key bottomOut function hook.