Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent crash when min. is higher than max. in expected range #14

Merged
merged 1 commit into from
Nov 25, 2023
Merged

Prevent crash when min. is higher than max. in expected range #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/geas_api.hrl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,7 +382,7 @@ compat(RootDir, print, Config) ->
lists:foreach(fun({LD, AD, RD, FD}) -> io:format(" ~-10s ~-10s ~-10s ~-20s ~20s~n",[LD, AD, RD, FD, get_version(FD)]) end, D),
io:format("~80s~n",[string:copies("-",80)]),
io:format(" ~-10s ~-10s ~-10s ~-20s ~20s~n",[MinGlob , ArchGlob, MaxGlob, "Global project", get_version(Project)]),
Rels = w2l({?GEAS_MIN_REL, MinGlob, MaxGlob, ?GEAS_MAX_REL}),
Rels = w2l({?GEAS_MIN_REL, MinGlob, MaxGlob, ?GEAS_MAX_REL}), % Might return empty list, if MinGlob is "higher" than MaxGlob.
io:format("~n",[]),
% Always display current version detected and patches found
Current = get_current_erlang_version(),
Expand Down Expand Up @@ -706,6 +706,8 @@ get_erlang_compat_beam(File) ->
%% @doc Check current Erlang release against project release window
%% @end
%%-------------------------------------------------------------------------
check_current_rel_vs_window(_Current, [] = _Window) ->
throw(5);
check_current_rel_vs_window(Current, Window)
->
Start = hd(Window),
Expand Down Expand Up @@ -770,5 +772,5 @@ format_error(1) -> "Current Erlang/OTP release is incompatible with project rel
format_error(2) -> "Release window do not match the required semver version range" ;
format_error(3) -> "Beam files are incompatible with current Erlang/OTP release (May need recompilation)" ;
format_error(4) -> "Maximum opcode is higher in Beam files (May need recompilation)" ;
format_error(5) -> "Release window do not match the required semver version frame" ;
format_error(5) -> "The release window does not match the required SemVer version frame" ;
format_error(_) -> "Unexpected exit code".
2 changes: 2 additions & 0 deletions src/geas_semver.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,8 @@ versionize(V) -> samovar:versionize(V).
%%-------------------------------------------------------------------------
-spec l2s(list()) -> {ok, list()} | {error, atom()}.

l2s([]) ->
{ok, []};
l2s(L) when is_list(L)
->
try
Expand Down