-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Activate auto registration token by default and update docs on authentication #231
Conversation
@srkoster: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.
DetailsI am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the forked project rr404/oss-governance-bot repository. |
@srkoster: There are no area labels on this PR. You can add as many areas as you see fit.
DetailsI am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the forked project rr404/oss-governance-bot repository. |
/kind enhancement |
Hello @srkoster thanks for the contribution! Is there a specific reason to remove the 192.168 network? |
@mmetc I removed 192.168 because it is used a lot for home LANs and then introduces a risk of overlap when being used for the Kubernetes network as well. Therefore I suspect that not many people are using it and I would rather keep the default list short / restrictive (to prevent auto registration from outside the Kubernetes network). They are however free to add the range to their own config. |
Look good to me but I would prefer to put the network back, I personally have created clusters with class A, B or C ranges and don't have data for how our users are configuring them |
@mmetc that's fair. I've put the range back in the values.yaml and the readme. |
Thanks @srkoster! |
values.yaml
(fix for Agents CrashLoopBackOff with 0.16.0 ("machine not validated"), but work with 0.15.0 #228)