Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't ask user to reload systemd service when running in docker #3434

Merged
merged 3 commits into from
Jan 31, 2025

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Jan 29, 2025

No description provided.

@mmetc mmetc added the kind/enhancement New feature or request label Jan 29, 2025
Copy link

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

codecov bot commented Jan 29, 2025

Codecov Report

Attention: Patch coverage is 75.86207% with 7 lines in your changes missing coverage. Please review.

Project coverage is 59.33%. Comparing base (172d6c6) to head (f7779c2).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
cmd/crowdsec-cli/reload/reload.go 28.57% 4 Missing and 1 partial ⚠️
cmd/crowdsec-cli/clihub/hub.go 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3434      +/-   ##
==========================================
- Coverage   59.34%   59.33%   -0.02%     
==========================================
  Files         361      362       +1     
  Lines       38953    38964      +11     
==========================================
+ Hits        23117    23119       +2     
- Misses      13911    13918       +7     
- Partials     1925     1927       +2     
Flag Coverage Δ
bats 41.60% <75.86%> (-0.01%) ⬇️
unit-linux 33.63% <0.00%> (-0.02%) ⬇️
unit-windows 28.39% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmetc
Copy link
Contributor Author

mmetc commented Jan 30, 2025

With the last change, restart message and user confirmation prompts are only displayed

  • if run in a shell (docker exec... then cscli)
  • if the container is started with run -ti

Is this ok @LaurenceJJones ?

@mmetc mmetc requested a review from LaurenceJJones January 30, 2025 08:32
@mmetc mmetc added this to the 1.6.6 milestone Jan 30, 2025
@LaurenceJJones LaurenceJJones modified the milestones: 1.6.6, 1.6.5 Jan 31, 2025
@LaurenceJJones LaurenceJJones merged commit bfed861 into master Jan 31, 2025
17 checks passed
@LaurenceJJones LaurenceJJones deleted the docker-reload branch January 31, 2025 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request needs/area
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants