Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint: gocritic/captLocal (don't capitalize local variables) #3402

Merged
merged 3 commits into from
Jan 16, 2025

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Jan 16, 2025

capitalized variables can be confused with exported symbols

Copy link

@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind refactoring
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 72.34043% with 39 lines in your changes missing coverage. Please review.

Project coverage is 59.14%. Comparing base (6529215) to head (71567a1).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
pkg/acquisition/modules/appsec/appsec.go 0.00% 14 Missing ⚠️
pkg/csprofiles/csprofiles.go 59.09% 6 Missing and 3 partials ⚠️
pkg/exprhelpers/helpers.go 72.72% 3 Missing and 3 partials ⚠️
pkg/acquisition/acquisition.go 60.00% 4 Missing ⚠️
pkg/database/flush.go 62.50% 3 Missing ⚠️
pkg/exprhelpers/crowdsec_cti.go 83.33% 1 Missing and 1 partial ⚠️
pkg/acquisition/modules/cloudwatch/cloudwatch.go 95.45% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3402   +/-   ##
=======================================
  Coverage   59.13%   59.14%           
=======================================
  Files         359      359           
  Lines       38730    38773   +43     
=======================================
+ Hits        22904    22933   +29     
- Misses      13901    13913   +12     
- Partials     1925     1927    +2     
Flag Coverage Δ
bats 42.21% <21.58%> (-0.07%) ⬇️
unit-linux 32.85% <70.99%> (+0.05%) ⬆️
unit-windows 28.19% <58.82%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmetc mmetc merged commit fe931af into master Jan 16, 2025
17 checks passed
@mmetc mmetc deleted the lint-captlocal branch January 16, 2025 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants