Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support dump: generate pprof files with debug=1 to avoid generating an unusable heap dump #3361

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

blotus
Copy link
Member

@blotus blotus commented Dec 11, 2024

For some reason that I cannot totally explain (and that doesn't seem to be documented), generating a heap dump with debug=1 makes it unusable for analysis with go tool pprof.

Let's just remove the parameter, it has not impact on the other profiles that are generated.

Copy link

@blotus: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind refactoring
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

@blotus: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.43%. Comparing base (dada07b) to head (a840151).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3361      +/-   ##
==========================================
- Coverage   58.43%   58.43%   -0.01%     
==========================================
  Files         351      351              
  Lines       37823    37823              
==========================================
- Hits        22103    22102       -1     
  Misses      13815    13815              
- Partials     1905     1906       +1     
Flag Coverage Δ
bats 41.26% <100.00%> (+0.04%) ⬆️
unit-linux 34.42% <0.00%> (+<0.01%) ⬆️
unit-windows 29.66% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blotus blotus merged commit d35d01f into master Dec 11, 2024
16 of 17 checks passed
@blotus blotus deleted the fix-support-dump-pprof branch December 11, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants