Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cscli: display expired decisions' expiration time in red #3357

Merged
merged 2 commits into from
Dec 11, 2024
Merged

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Dec 10, 2024

had a customer testing the bouncer without noticing the decisions were expired.

@mmetc mmetc added the kind/enhancement New feature or request label Dec 10, 2024
@mmetc mmetc added this to the 1.6.5 milestone Dec 10, 2024
Copy link

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@mmetc mmetc marked this pull request as ready for review December 10, 2024 08:58
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.

Project coverage is 58.43%. Comparing base (88c5f85) to head (acd8aab).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
cmd/crowdsec-cli/clidecision/table.go 57.14% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3357      +/-   ##
==========================================
+ Coverage   58.39%   58.43%   +0.04%     
==========================================
  Files         351      351              
  Lines       37818    37823       +5     
==========================================
+ Hits        22082    22102      +20     
+ Misses      13828    13817      -11     
+ Partials     1908     1904       -4     
Flag Coverage Δ
bats 41.28% <57.14%> (+0.12%) ⬆️
unit-linux 34.42% <0.00%> (-0.01%) ⬇️
unit-windows 29.66% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@sabban sabban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mmetc mmetc changed the title cscli decisions: display negative expiration times in red cscli: display expired decisions' expiration time in red Dec 11, 2024
@mmetc mmetc merged commit dada07b into master Dec 11, 2024
17 checks passed
@mmetc mmetc deleted the neg-duration branch December 11, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request needs/area
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants