Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove dependency from pkg/cwversion to pkg/acquisition #3242

Merged
merged 4 commits into from
Sep 20, 2024
Merged

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Sep 17, 2024

This allows to build cscli with no datasource code if csli_setup is excluded from the build.

@mmetc mmetc added this to the 1.6.4 milestone Sep 17, 2024
Copy link

@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind refactoring
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@mmetc mmetc requested a review from blotus September 17, 2024 09:30
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 77.50000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 51.29%. Comparing base (00032d4) to head (e3d68a8).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
pkg/cwversion/component/component.go 33.33% 3 Missing and 1 partial ⚠️
pkg/acquisition/acquisition.go 87.50% 1 Missing and 1 partial ⚠️
pkg/cwversion/version.go 83.33% 2 Missing ⚠️
cmd/crowdsec-cli/setup.go 80.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3242   +/-   ##
=======================================
  Coverage   51.29%   51.29%           
=======================================
  Files         355      357    +2     
  Lines       38869    38891   +22     
=======================================
+ Hits        19936    19948   +12     
- Misses      16970    16977    +7     
- Partials     1963     1966    +3     
Flag Coverage Δ
bats 40.92% <82.14%> (-0.01%) ⬇️
unit-linux 34.66% <42.85%> (-0.01%) ⬇️
unit-windows 28.62% <37.50%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmetc mmetc requested review from sabban and removed request for blotus September 18, 2024 10:02
@mmetc mmetc requested review from blotus and removed request for sabban September 19, 2024 13:25
Copy link
Contributor

@sabban sabban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mmetc mmetc removed the request for review from blotus September 20, 2024 07:54
@mmetc mmetc merged commit e2196bd into master Sep 20, 2024
17 checks passed
@mmetc mmetc deleted the cscli-component branch September 20, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants