Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable linter: revive (early-return) #3051

Merged
merged 2 commits into from
Jun 7, 2024
Merged

enable linter: revive (early-return) #3051

merged 2 commits into from
Jun 7, 2024

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Jun 4, 2024

No description provided.

@mmetc mmetc added this to the 1.6.3 milestone Jun 4, 2024
Copy link

github-actions bot commented Jun 4, 2024

@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind refactoring
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

github-actions bot commented Jun 4, 2024

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

codecov bot commented Jun 4, 2024

Codecov Report

Attention: Patch coverage is 41.46341% with 24 lines in your changes missing coverage. Please review.

Project coverage is 52.48%. Comparing base (550d422) to head (4c542dd).
Report is 1 commits behind head on master.

Files Patch % Lines
pkg/apiserver/papi.go 0.00% 8 Missing ⚠️
pkg/appsec/appsec_rule/modsecurity.go 57.14% 4 Missing and 2 partials ⚠️
pkg/acquisition/modules/s3/s3.go 70.00% 3 Missing ⚠️
pkg/appsec/coraza_logger.go 25.00% 3 Missing ⚠️
pkg/csplugin/hclog_adapter.go 0.00% 2 Missing ⚠️
pkg/exprhelpers/crowdsec_cti.go 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3051      +/-   ##
==========================================
- Coverage   52.48%   52.48%   -0.01%     
==========================================
  Files         281      281              
  Lines       35423    35415       -8     
==========================================
- Hits        18593    18587       -6     
  Misses      15008    15008              
+ Partials     1822     1820       -2     
Flag Coverage Δ
bats 40.23% <0.00%> (+<0.01%) ⬆️
unit-linux 34.85% <40.54%> (+<0.01%) ⬆️
unit-windows 30.97% <39.02%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmetc mmetc force-pushed the lint-early-return branch 3 times, most recently from 043146f to 790d4ac Compare June 5, 2024 10:02
@mmetc mmetc requested review from blotus and removed request for sabban June 7, 2024 13:42
@mmetc mmetc force-pushed the lint-early-return branch from 790d4ac to 4c542dd Compare June 7, 2024 14:30
@mmetc mmetc merged commit 72b6da9 into master Jun 7, 2024
17 checks passed
@mmetc mmetc deleted the lint-early-return branch June 7, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants