Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improved tls middleware revocation checks #3034

Merged
merged 31 commits into from
Jun 26, 2024
Merged

improved tls middleware revocation checks #3034

merged 31 commits into from
Jun 26, 2024

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented May 29, 2024

No description provided.

Copy link

@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind refactoring
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@mmetc mmetc added the kind/enhancement New feature or request label May 29, 2024
@mmetc mmetc added this to the 1.6.3 milestone May 29, 2024
Copy link

codecov bot commented May 29, 2024

Codecov Report

Attention: Patch coverage is 48.36601% with 158 lines in your changes missing coverage. Please review.

Project coverage is 52.62%. Comparing base (3097c0c) to head (48a8229).

Files Patch % Lines
pkg/apiserver/middlewares/v1/ocsp.go 10.93% 57 Missing ⚠️
pkg/apiserver/middlewares/v1/crl.go 48.31% 36 Missing and 10 partials ⚠️
pkg/apiserver/middlewares/v1/tls_auth.go 68.75% 19 Missing and 6 partials ⚠️
pkg/apiserver/middlewares/v1/cache.go 59.32% 23 Missing and 1 partial ⚠️
pkg/apiserver/middlewares/v1/jwt.go 50.00% 5 Missing ⚠️
pkg/apiserver/middlewares/v1/api_key.go 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3034      +/-   ##
==========================================
+ Coverage   52.58%   52.62%   +0.04%     
==========================================
  Files         281      284       +3     
  Lines       35387    35505     +118     
==========================================
+ Hits        18607    18686      +79     
- Misses      14969    15004      +35     
- Partials     1811     1815       +4     
Flag Coverage Δ
bats 40.56% <60.74%> (+0.21%) ⬆️
unit-linux 34.72% <0.00%> (-0.12%) ⬇️
unit-windows 30.86% <0.32%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmetc mmetc marked this pull request as ready for review May 30, 2024 10:42
@mmetc mmetc requested a review from blotus May 30, 2024 13:44
@mmetc mmetc force-pushed the crl branch 3 times, most recently from daf1f84 to e21fe03 Compare June 7, 2024 07:47
@mmetc mmetc force-pushed the crl branch 5 times, most recently from cab879b to 4d853e5 Compare June 12, 2024 06:11
@mmetc mmetc requested a review from buixor June 14, 2024 08:11
@mmetc mmetc requested a review from buixor June 26, 2024 08:00
Copy link
Contributor

@buixor buixor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mmetc mmetc merged commit a3bd9ba into master Jun 26, 2024
17 checks passed
@mmetc mmetc deleted the crl branch June 26, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request needs/area
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants