Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix tests #191

Merged
merged 7 commits into from
Aug 24, 2020
Merged

fix tests #191

merged 7 commits into from
Aug 24, 2020

Conversation

erenJag
Copy link
Contributor

@erenJag erenJag commented Aug 21, 2020

  • fix tests
  • update documentation
  • add more tests for exprhelpers pkg

@erenJag erenJag changed the title fix leakybucket test fix tests Aug 21, 2020
@erenJag erenJag added the bugfix label Aug 21, 2020
Copy link
Contributor

@buixor buixor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments, plus can we have some tests with unspecified / unknown types for data sources plz ?

Copy link
Contributor

@buixor buixor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@buixor buixor merged commit 6624fce into master Aug 24, 2020
@buixor buixor deleted the fix_tests branch August 24, 2020 08:25
registergoofy pushed a commit that referenced this pull request Sep 7, 2020
* fix leakybucket test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants