Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No sql transaction + proper time-machine wait #148

Merged
merged 5 commits into from
Jul 27, 2020
Merged

No sql transaction + proper time-machine wait #148

merged 5 commits into from
Jul 27, 2020

Conversation

buixor
Copy link
Contributor

@buixor buixor commented Jul 27, 2020

  • Do not use transactions to commit changes to DB
  • Have a smarter mechanism waiting for "pending" buckets that overflowed but didn't commit to DB yet (for time-machine)

AlteredCoder
AlteredCoder reviewed Jul 27, 2020
View reviewed changes
@AlteredCoder AlteredCoder merged commit 151af2d into master Jul 27, 2020
@AlteredCoder AlteredCoder deleted the no_sql_transaction branch July 27, 2020 11:42
@buixor buixor mentioned this pull request Jul 28, 2020
Closed
registergoofy pushed a commit that referenced this pull request Sep 7, 2020
@buixor @registergoofy
No sql transaction + proper time-machine wait (#148)
1be0deb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlteredCoder AlteredCoder AlteredCoder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@buixor @AlteredCoder