Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upload screenshots improvements #853

Merged
merged 2 commits into from
Oct 14, 2024
Merged

Conversation

yevheniyJ
Copy link
Collaborator

@yevheniyJ yevheniyJ commented Oct 12, 2024

  • improved screenshot search
  • usePreviousTags option in request
  • replace tags conditional request

Copy link

codecov bot commented Oct 12, 2024

Codecov Report

Attention: Patch coverage is 48.83721% with 22 lines in your changes missing coverage. Please review.

Project coverage is 65.74%. Comparing base (af8bd46) to head (4b08860).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...n/cli/commands/actions/ScreenshotUploadAction.java 63.64% 9 Missing and 3 partials ⚠️
...om/crowdin/cli/client/CrowdinClientScreenshot.java 0.00% 10 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #853      +/-   ##
============================================
- Coverage     65.90%   65.74%   -0.16%     
+ Complexity     1522     1521       -1     
============================================
  Files           225      225              
  Lines          6210     6233      +23     
  Branches        940      942       +2     
============================================
+ Hits           4092     4097       +5     
- Misses         1576     1592      +16     
- Partials        542      544       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrii-bodnar andrii-bodnar merged commit 32ea5f6 into main Oct 14, 2024
16 checks passed
@andrii-bodnar andrii-bodnar deleted the upload-screenshots-improve branch October 14, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants