Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#480 Add '--dryrun' mode to the 'download sources' command #485

Merged
merged 4 commits into from
Oct 4, 2022

Conversation

kiatt210
Copy link
Contributor

@kiatt210 kiatt210 commented Oct 3, 2022

No description provided.

@codecov
Copy link

codecov bot commented Oct 3, 2022

Codecov Report

Merging #485 (07b20d9) into cli3 (e411e29) will increase coverage by 0.04%.
The diff coverage is 20.00%.

@@             Coverage Diff              @@
##               cli3     #485      +/-   ##
============================================
+ Coverage     56.32%   56.35%   +0.04%     
- Complexity      960      962       +2     
============================================
  Files           153      153              
  Lines          4757     4758       +1     
  Branches        728      728              
============================================
+ Hits           2679     2681       +2     
+ Misses         1728     1726       -2     
- Partials        350      351       +1     
Impacted Files Coverage Δ
...li/commands/picocli/DownloadSourcesSubcommand.java 33.34% <0.00%> (ø)
...in/cli/commands/actions/DownloadSourcesAction.java 47.86% <25.00%> (+0.94%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@andrii-bodnar andrii-bodnar linked an issue Oct 3, 2022 that may be closed by this pull request
@andrii-bodnar
Copy link
Member

Hi @kiatt210, Thanks a lot for your contribution! 🎉

Please check the minor comments I've made to this PR

@kiatt210
Copy link
Contributor Author

kiatt210 commented Oct 4, 2022

Hi @andrii-bodnar, I fixed the indentations.

@andrii-bodnar
Copy link
Member

Hi @kiatt210, thanks, looks good to me!

@andrii-bodnar andrii-bodnar merged commit 75bb368 into crowdin:cli3 Oct 4, 2022
@kiatt210 kiatt210 deleted the #480 branch October 5, 2022 05:11
@andrii-bodnar andrii-bodnar mentioned this pull request Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add '--dryrun' mode to the 'download sources' command
2 participants