-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing groupId inside list glossaries/projects #77
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dhoko thank you!
@dhoko Unit tests have failed. Could you please take a look? https://github.com/crowdin/crowdin-api-client-python/actions/runs/4799498715 |
@andrii-bodnar ✔️ btw there is an issue with the coverage. When I install the deps it fails at
Then we can't run pytest unless we comment the coverage cf: diff --git a/setup.cfg b/setup.cfg
index fdbb3b3..7221536 100644
--- a/setup.cfg
+++ b/setup.cfg
@@ -60,10 +60,6 @@ addopts =
--strict-markers
--tb=short
--doctest-modules
- --cov=crowdin_api
- --cov-report=term-missing:skip-covered
- --cov-report=xml
- --cov-fail-under=95 |
Codecov Report
@@ Coverage Diff @@
## main #77 +/- ##
==========================================
+ Coverage 99.34% 99.34% +0.01%
==========================================
Files 132 132
Lines 4493 4496 +3
Branches 95 95
==========================================
+ Hits 4463 4466 +3
Misses 22 22
Partials 8 8
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@dhoko thank you! Do you have any ideas regarding this coverage error? Everything seems to work well in the CI/CD pipelines |
Idk ¯_(ツ)_/¯ I saw messages asking to install python3-dev... So I went with no coverage on my computer 😁 It requires no changes and we can still test everything^^ |
tl;dr: EOL + I'm using python 3.11 -> no support |
Hey 👋
There was a missing
groupId
for 2 GET calls, It didn't match the API definition for: