Move config parameters from class to instance #20

[svenXY]

Implements a possible solution for #20

[svenXY]

OK, this does not work. It seems that constants changed in the subclass are somehow lost.

You are right - the problem is how to implement the new interface while keeping the old one as they contradict each other

[svenXY]

OK, the current version passes all tests. Maybe you could restart the test suites on your side?

[andrii-bodnar]

@svenXY something wrong, the checks have failed again

[svenXY]

ah, yes: https://docs.python.org/3.10/whatsnew/3.10.html#pep-604-new-type-union-operator - i have str|None which is only supported since 3.10.

https://docs.python.org/3.10/library/typing.html#typing.Optional

[andrii-bodnar]

@svenXY hmm, do you have any ideas on how to fix that? We need to support at least 3.6+ Python versions

[svenXY]

Should work now. But honestly, maybe it is really better to drop the old approach with class constants as that would also mean that we could drop most of the Optional[]s in __init__()

[svenXY]

this last failure is something else and has afaiu nothing to do with my code:

'{'detail': ErrorDetail(string='Unable to locate build via Github Actions API. Please upload with the Codecov repository upload token to resolve issue.', code='not_found')}'

[andrii-bodnar]

@svenXY Thank you!

Yes, it's something not related to your changes. Will try to investigate that