Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ai): support for AI resource #166

Merged
merged 6 commits into from
Jul 1, 2024
Merged

Conversation

OmAximani0
Copy link
Contributor

@codecov-commenter
Copy link

codecov-commenter commented Jun 25, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@67a979e). Learn more about missing BASE report.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #166   +/-   ##
=======================================
  Coverage        ?   99.25%           
=======================================
  Files           ?      166           
  Lines           ?     6450           
  Branches        ?      876           
=======================================
  Hits            ?     6401           
  Misses          ?       34           
  Partials        ?       15           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@OmAximani0 OmAximani0 marked this pull request as ready for review June 25, 2024 13:30
@andrii-bodnar
Copy link
Member

@OmAximani0 thanks for the contribution!

The Crowdin Enterprise version of these API endpoints has a different request URL (without the userId subpath)

https://developer.crowdin.com/enterprise/api/v2/#operation/api.ai.prompts.getMany

A similar situation existed in PR #162. Please consider the same approach in the current implementation.

@OmAximani0
Copy link
Contributor Author

@OmAximani0 thanks for the contribution!

The Crowdin Enterprise version of these API endpoints has a different request URL (without the userId subpath)

https://developer.crowdin.com/enterprise/api/v2/#operation/api.ai.prompts.getMany

A similar situation existed in PR #162. Please consider the same approach in the current implementation.

Hi @andrii-bodnar , I have implemented the same approach as mentioned, please proceed to review the PR.

Thank you.

Copy link
Member

@andrii-bodnar andrii-bodnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@OmAximani0 thank you!

@andrii-bodnar andrii-bodnar merged commit f21813f into crowdin:main Jul 1, 2024
6 checks passed
@OmAximani0 OmAximani0 deleted the feat/ai branch October 7, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AI API support
3 participants