Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(users): Fix list project members API endpoint for enterprise. #158

Merged

Conversation

dpaskov
Copy link
Contributor

@dpaskov dpaskov commented May 13, 2024

For the enterprise endpoint the API accepts workflowStepId instead of role.

Copy link
Member

@andrii-bodnar andrii-bodnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dpaskov thank you for the contribution!

I wonder if Python supports such method overloading?

@andrii-bodnar
Copy link
Member

I've made some fixes to the CI/CD workflows, could you please rebase the branch?

For the enterprise endpoint the API accepts workflowStepId instead of role.
@dpaskov dpaskov force-pushed the fix/list-project-members-enterprise branch from 6937b6f to 218b202 Compare May 14, 2024 07:36
@codecov-commenter
Copy link

codecov-commenter commented May 14, 2024

Codecov Report

Attention: Patch coverage is 96.42857% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 99.16%. Comparing base (1dc2658) to head (eeb4abe).

Files Patch % Lines
crowdin_api/api_resources/users/resource.py 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #158      +/-   ##
==========================================
- Coverage   99.18%   99.16%   -0.01%     
==========================================
  Files         160      160              
  Lines        5819     5832      +13     
  Branches      791      795       +4     
==========================================
+ Hits         5771     5783      +12     
  Misses         34       34              
- Partials       14       15       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dpaskov
Copy link
Contributor Author

dpaskov commented May 14, 2024

Hey @andrii-bodnar,
Python does support this method overloading, but it's not a best practice. I've pushed a better and more reusable approach.

Copy link
Member

@andrii-bodnar andrii-bodnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dpaskov thank you!

@andrii-bodnar andrii-bodnar merged commit 3aabdc1 into crowdin:main May 14, 2024
6 checks passed
@dpaskov dpaskov deleted the fix/list-project-members-enterprise branch May 14, 2024 08:19
@dpaskov
Copy link
Contributor Author

dpaskov commented May 14, 2024

@andrii-bodnar No problem at all.
Just for info, what is the release schedule for this library. 🙂

@andrii-bodnar
Copy link
Member

@dpaskov available in 1.15.1 😎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants