Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): Screenshots APIs: add new parameters support #141

Merged
merged 6 commits into from
Nov 30, 2023
Merged

feat(api): Screenshots APIs: add new parameters support #141

merged 6 commits into from
Nov 30, 2023

Conversation

Mahhheshh
Copy link
Contributor

closes #139

This PR Addes/Updates.

The optional labelIds parameter has been added to add_screenshot. tests for adding screenshot has been updated to test the changes.

In crowdin_api/api_resources/screenshots/types.py the type hinting for value has been changed from Any to str. docs

@andrii-bodnar
Copy link
Member

Hi @Mahhheshh, could you please address the CI issues? Thanks.

@andrii-bodnar
Copy link
Member

@Mahhheshh could you please also update the List Screenshots interface?

@Mahhheshh
Copy link
Contributor Author

Sure I will update the List Screen Shots interface also.

@codecov-commenter
Copy link

codecov-commenter commented Nov 29, 2023

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.17%. Comparing base (b6685c9) to head (3d329bc).
Report is 26 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #141      +/-   ##
==========================================
+ Coverage   99.17%   99.17%   +0.01%     
==========================================
  Files         149      149              
  Lines        5493     5495       +2     
  Branches      752      752              
==========================================
+ Hits         5447     5449       +2     
  Misses         33       33              
  Partials       13       13              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Mahhheshh
Copy link
Contributor Author

It seems that I misinterpreted the documentation.

crowdin_api/api_resources/abstract/resources.py Outdated Show resolved Hide resolved
crowdin_api/api_resources/screenshots/resource.py Outdated Show resolved Hide resolved
crowdin_api/api_resources/screenshots/resource.py Outdated Show resolved Hide resolved
crowdin_api/api_resources/screenshots/resource.py Outdated Show resolved Hide resolved
crowdin_api/api_resources/screenshots/resource.py Outdated Show resolved Hide resolved
crowdin_api/api_resources/screenshots/resource.py Outdated Show resolved Hide resolved
crowdin_api/api_resources/screenshots/resource.py Outdated Show resolved Hide resolved
@andrii-bodnar andrii-bodnar changed the title feat(api): Support for feat(api): Screenshots APIs: add new parameter support Nov 30, 2023
Copy link
Member

@andrii-bodnar andrii-bodnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mahhheshh thank you!

@andrii-bodnar andrii-bodnar changed the title feat(api): Screenshots APIs: add new parameter support feat(api): Screenshots APIs: add new parameters support Nov 30, 2023
@andrii-bodnar andrii-bodnar merged commit b4075ab into crowdin:main Nov 30, 2023
8 checks passed
@Mahhheshh Mahhheshh deleted the add-labelId-param branch November 30, 2023 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Screenshots APIs: add the labelIds parameter support
3 participants