-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api): Screenshots APIs: add new parameters support #141
Conversation
Hi @Mahhheshh, could you please address the CI issues? Thanks. |
@Mahhheshh could you please also update the List Screenshots interface? |
Sure I will update the List Screen Shots interface also. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #141 +/- ##
==========================================
+ Coverage 99.17% 99.17% +0.01%
==========================================
Files 149 149
Lines 5493 5495 +2
Branches 752 752
==========================================
+ Hits 5447 5449 +2
Misses 33 33
Partials 13 13 ☔ View full report in Codecov by Sentry. |
It seems that I misinterpreted the documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Mahhheshh thank you!
closes #139
This PR Addes/Updates.
The optional
labelIds
parameter has been added toadd_screenshot
. tests for adding screenshot has been updated to test the changes.In
crowdin_api/api_resources/screenshots/types.py
the type hinting forvalue
has been changed fromAny
tostr
. docs