-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: project_id
as property
#129
Conversation
Codecov Report
@@ Coverage Diff @@
## main #129 +/- ##
==========================================
- Coverage 99.20% 99.18% -0.02%
==========================================
Files 146 146
Lines 5088 5425 +337
Branches 717 745 +28
==========================================
+ Hits 5047 5380 +333
- Misses 29 32 +3
- Partials 12 13 +1
|
@andrii-bodnar Please checkout these changes and I have not done changes in tests but the builds are passing please suggest changes according |
crowdin_api/api_resources/bundles/tests/test_bundles_resources.py
Outdated
Show resolved
Hide resolved
@andrii-bodnar Please checkout below resources in which I have made the changes according to previous changes suggested and please inform me that can I change all the other API resources according to these below resources? |
@OmAximani0 this looks good to me. The only thing I'd suggest changing is: projectId = projectId if projectId else self.get_project_id() can be simplified: projectId = projectId or self.get_project_id() |
@andrii-bodnar Fine then, I'll implement the line as you suggested and I'll also change the other API resources according to it 👍 |
crowdin_api/api_resources/languages/tests/test_languages_resources.py
Outdated
Show resolved
Hide resolved
Signed-off-by: OmAxiani0 <[email protected]>
b03c550
to
81302b7
Compare
Co-authored-by: Andrii Bodnar <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@OmAximani0 thank you!
For now it is just configured, I will push the implementation all over the code-base on this branch only.
ToDo's
project_id
as optional param for all API resourcesREADME.md