Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Bumped up the dependency versions #101

Merged
merged 5 commits into from
Sep 12, 2023

Conversation

OmAximani0
Copy link
Contributor

@OmAximani0 OmAximani0 commented Sep 7, 2023

- The versions are taken according PyPIs latest version

Signed-off-by: OmAxiani0 <[email protected]>
Signed-off-by: OmAxiani0 <[email protected]>
@OmAximani0 OmAximani0 changed the title Bumped up the dependency versions fix: Bumped up the dependency versions Sep 7, 2023
@andrii-bodnar
Copy link
Member

@OmAximani0 probably we should also bump the CI Python version to at least 3.8

@OmAximani0
Copy link
Contributor Author

@OmAximani0 probably we should also bump the CI Python version to at least 3.8

If that's ok, we should do that . Cause I was just updating the version according to 3.7

@andrii-bodnar
Copy link
Member

I guess this version is pretty old and other tools don't support it anymore, right?

@OmAximani0
Copy link
Contributor Author

I guess this version is pretty old and other tools don't support it anymore, right?

Yep, I also think so

@OmAximani0
Copy link
Contributor Author

And @andrii-bodnar , I also think that we could support 3.10 and remove the 3.7.

@andrii-bodnar
Copy link
Member

@OmAximani0 yes, it would be great, thank you!

@OmAximani0
Copy link
Contributor Author

Hey @andrii-bodnar , can I get to know about any update on this ?

@andrii-bodnar
Copy link
Member

@OmAximani0 please update the CI Python versions within the current PR

@OmAximani0
Copy link
Contributor Author

@OmAximani0 please update the CI Python versions within the current PR

Bump up to 3.8 right ?

@andrii-bodnar
Copy link
Member

@OmAximani0
Copy link
Contributor Author

I guess you can set the 3.8, 3.9, and 3.10 here https://github.com/crowdin/crowdin-api-client-python/blob/main/.github/workflows/python-package.yml#L18

Ok, got it 👍

@andrii-bodnar
Copy link
Member

@OmAximani0 please bump to 3.8 in other workflows as well

@OmAximani0
Copy link
Contributor Author

I think we need to update setup.cfg like this

@andrii-bodnar
Copy link
Member

@OmAximani0 sounds pretty fair

Signed-off-by: OmAxiani0 <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Merging #101 (68fd276) into main (72d981f) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #101      +/-   ##
==========================================
- Coverage   99.29%   99.25%   -0.04%     
==========================================
  Files         132      132              
  Lines        4495     4495              
  Branches       96      108      +12     
==========================================
- Hits         4463     4461       -2     
  Misses         23       23              
- Partials        9       11       +2     

see 2 files with indirect coverage changes

Copy link
Member

@andrii-bodnar andrii-bodnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@OmAximani0 thank you!

@andrii-bodnar andrii-bodnar merged commit 52767cf into crowdin:main Sep 12, 2023
4 checks passed
@OmAximani0 OmAximani0 deleted the dependency branch September 13, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error while setting up dev environment
3 participants