-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add AI Setting Methods #279
Conversation
Summary: - Added methods for AI setting methods for. - reference: https://support.crowdin.com/developer/api/v2/#tag/AI/operation/api.users.ai.settings.get.
@vedantnd111 as I can see from the failed CI build, there is an issue in the tests code: > Task :compileTestJava
/home/runner/work/crowdin-api-client-java/crowdin-api-client-java/src/test/java/com/crowdin/client/ai/AiApiTest.java:25: error: cannot find symbol
return List.of(RequestMock.build(settingsApi, HttpGet.METHOD_NAME, "api/ai/getAiSettingResponse.json"),
^
symbol: method of(RequestMock,RequestMock)
location: interface List
|
I have made some changes to fix this. Please check. |
|
||
@Test | ||
public void getAiSettingTest() { | ||
System.out.println("test-url: " + settingsApi); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might want to remove this line of code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed log statments, but tests are failing because received response is null. I was not able to debug this, could you PTAL?
@vedantnd111 i think it will be better to have a single commit |
@vedantnd111 the CI is failing: > Task :test
AiApiTest > getAiSettingTest() FAILED
org.opentest4j.AssertionFailedError at AiApiTest.java:35
AiApiTest > editAiSettingTest() FAILED
org.opentest4j.AssertionFailedError at AiApiTest.java:48
364 tests completed, 2 failed Please take a look. |
@vedantnd111 please rebase your PR. The AI package (partial) has recently been added to the repo (https://github.com/crowdin/crowdin-api-client-java/tree/master/src/main/java/com/crowdin/client/ai) |
Created PR: #281 instead of this. PTAL. |
Summary: