Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add updateOption field to UploadStringsRequest #264

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

Besomhead
Copy link
Contributor

  • Added updateOption field to strings upload request and progress response according to API Reference docs.
  • Covered logic with tests.

Covers #260.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.33%. Comparing base (a7981ef) to head (6fbd707).

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #264      +/-   ##
============================================
+ Coverage     93.26%   93.33%   +0.07%     
- Complexity      721      726       +5     
============================================
  Files           181      182       +1     
  Lines          2359     2367       +8     
  Branches         48       50       +2     
============================================
+ Hits           2200     2209       +9     
+ Misses          135      134       -1     
  Partials         24       24              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrii-bodnar andrii-bodnar changed the title feat: add updateOption field to UploadStringsRequest. feat: add updateOption field to UploadStringsRequest Oct 3, 2024
@andrii-bodnar andrii-bodnar linked an issue Oct 3, 2024 that may be closed by this pull request
Copy link
Member

@andrii-bodnar andrii-bodnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Besomhead thank you!

@andrii-bodnar andrii-bodnar merged commit 254a1a1 into crowdin:master Oct 3, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upload Strings API: add new updateOption parameter
3 participants