-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Screenshots APIs: add the stringIds parameter support #259
The head ref may contain hidden characters: "feataure\uFF1Aadd_the_stringIds_parameter_support"
feat: Screenshots APIs: add the stringIds parameter support #259
Conversation
@cmgyqjj thanks for the contribution! It seems that the PR title doesn't represent the actual changes made here. |
src/main/java/com/crowdin/client/screenshots/ScreenshotsApi.java
Outdated
Show resolved
Hide resolved
This change will break the existing integrations. I would suggest creating an overloaded method with the new parameter number and deprecate the existing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #259 +/- ##
============================================
+ Coverage 93.25% 93.28% +0.03%
- Complexity 716 717 +1
============================================
Files 180 180
Lines 2340 2348 +8
Branches 47 47
============================================
+ Hits 2182 2190 +8
Misses 135 135
Partials 23 23 ☔ View full report in Codecov by Sentry. |
@andrii-bodnar Thank you for your patience in pointing out my mistake. The incorrect title has been corrected, and this time we have used an overloaded method to avoid affecting the existing integrations. Additionally, we have added unit tests and formatted the submitted code to be consistent with the project. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cmgyqjj thank you!
I have carefully reviewed the documentation and have added the
stringIds
,labelIds
, andexcludeLabelIds
parameters to theScreenshotsApi.listScreenshots
method. Additionally, I have marked thestringId
parameter as deprecated.