Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Screenshots APIs: add the stringIds parameter support #259

Conversation

cmgyqjj
Copy link
Contributor

@cmgyqjj cmgyqjj commented Sep 16, 2024

I have carefully reviewed the documentation and have added the stringIds, labelIds, and excludeLabelIds parameters to the ScreenshotsApi.listScreenshots method. Additionally, I have marked the stringId parameter as deprecated.

@cmgyqjj cmgyqjj changed the title feature: defaultTmId,_defaultGlossaryId_support feat: defaultTmId,_defaultGlossaryId_support Sep 16, 2024
@andrii-bodnar
Copy link
Member

@cmgyqjj thanks for the contribution!

It seems that the PR title doesn't represent the actual changes made here.

@andrii-bodnar
Copy link
Member

This change will break the existing integrations. I would suggest creating an overloaded method with the new parameter number and deprecate the existing listScreenshots.

@andrii-bodnar andrii-bodnar linked an issue Sep 16, 2024 that may be closed by this pull request
@cmgyqjj cmgyqjj changed the title feat: defaultTmId,_defaultGlossaryId_support feat: Screenshots APIs: add the stringIds parameter support Sep 16, 2024
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.28%. Comparing base (9542494) to head (9af7bcf).
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #259      +/-   ##
============================================
+ Coverage     93.25%   93.28%   +0.03%     
- Complexity      716      717       +1     
============================================
  Files           180      180              
  Lines          2340     2348       +8     
  Branches         47       47              
============================================
+ Hits           2182     2190       +8     
  Misses          135      135              
  Partials         23       23              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmgyqjj
Copy link
Contributor Author

cmgyqjj commented Sep 16, 2024

@andrii-bodnar Thank you for your patience in pointing out my mistake. The incorrect title has been corrected, and this time we have used an overloaded method to avoid affecting the existing integrations. Additionally, we have added unit tests and formatted the submitted code to be consistent with the project.

Copy link
Member

@andrii-bodnar andrii-bodnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cmgyqjj thank you!

@andrii-bodnar andrii-bodnar merged commit 3a8316e into crowdin:master Sep 16, 2024
2 checks passed
@cmgyqjj cmgyqjj deleted the feataure:add_the_stringIds_parameter_support branch September 16, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Screenshots APIs: add the stringIds parameter support
3 participants