Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: batch error response processing #255

Merged

Conversation

mmuruev
Copy link
Contributor

@mmuruev mmuruev commented Sep 6, 2024

Fix for bulk request errors.

@codecov-commenter
Copy link

codecov-commenter commented Sep 6, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.

Project coverage is 93.24%. Comparing base (9542494) to head (5a9c8ca).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...ttp/impl/json/CrowdinApiExceptionDeserializer.java 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #255      +/-   ##
============================================
- Coverage     93.25%   93.24%   -0.01%     
- Complexity      716      719       +3     
============================================
  Files           180      181       +1     
  Lines          2340     2351      +11     
  Branches         47       48       +1     
============================================
+ Hits           2182     2192      +10     
  Misses          135      135              
- Partials         23       24       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrii-bodnar andrii-bodnar changed the title Fix for bulk error response fix: batch error response processing Sep 6, 2024
@andrii-bodnar andrii-bodnar linked an issue Sep 6, 2024 that may be closed by this pull request
@mmuruev mmuruev force-pushed the bugfix/254-bulk-upload-error-response-fix branch from 53ce256 to 829fb92 Compare September 24, 2024 08:01
Copy link
Member

@andrii-bodnar andrii-bodnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mmuruev thank you!

@andrii-bodnar andrii-bodnar merged commit f54ada9 into crowdin:master Sep 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Impossible dentify error source with batch upload (PATCH)
3 participants