feat: Added AI related API support #249
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrii-bodnar
requested changes
May 29, 2024
| * <li><a href="https://developer.crowdin.com/api/v2/#operation/api.ai.prompts.getMany" target="_blank"><b>API Documentation</b></a></li> | ||
| * </ul> | ||
| */ | ||
| public ResponseList<AiPrompt> listAiPrompts (Long userId, Long projectId, String action, Long limit, Integer offset) throws HttpException, HttpBadRequestException { |
There was a problem hiding this comment.
Suggested change
| public ResponseList<AiPrompt> listAiPrompts (Long userId, Long projectId, String action, Long limit, Integer offset) throws HttpException, HttpBadRequestException { | |
| public ResponseList<AiPrompt> listAiPrompts(Long userId, Long projectId, String action, Long limit, Integer offset) throws HttpException, HttpBadRequestException { |
Usually we don't put a space after the method name. Please fix this here and in other methods
| "limit", Optional.ofNullable(limit), | ||
| "offset", Optional.ofNullable(offset) | ||
| ); | ||
| AiPromptResponseList aiPromptResponseList = this.httpClient.get(this.url + "/users/" + userId + "/ai/prompts", new HttpRequestConfig(queryParams), AiPromptResponseList.class); |
There was a problem hiding this comment.
The Crowdin Enterprise version of these API endpoints has a different request URL (without the userId subpath)
https://developer.crowdin.com/enterprise/api/v2/#operation/api.ai.prompts.getMany
A similar situation existed in PR #242. Please consider the same approach in the current implementation.
| AiPromptResponseObject response = this.httpClient.get(this.url + "/users/" + userId + "/ai/prompts/" + aiPromptId, new HttpRequestConfig(), AiPromptResponseObject.class); | ||
| return ResponseObject.of(response.getData()); | ||
| } | ||
|
|
| * @param request request object | ||
| * @return newly created Ai prompt | ||
| * @see <ul> | ||
| * <li><a href="https://developer.crowdin.com/api/v2/#operation/api.users.ai.prompts.post" target="_blank"><b>API Documentation</b></a></li> |
There was a problem hiding this comment.
Missing Crowdin Enterprise links
| @@ -0,0 +1,24 @@ | |||
| { | |||
| } | ||
|
|
||
| @Test | ||
| public void listAiPromptTest(){ |
There was a problem hiding this comment.
Suggested change
| public void listAiPromptTest(){ | |
| public void listAiPromptTest() { |
|
Hi @Durdush, could you please take a look at the discussions? Thanks! |
Closed
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.