Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: String based api support (Clients, Bundles, Distributions, Labels, Machine Translations) #224

Merged
merged 10 commits into from
Mar 25, 2024

Conversation

Zahid92
Copy link
Contributor

@Zahid92 Zahid92 commented Feb 28, 2024

Yet to complete, Initially I was trying to get it done in a single chunk, realized my mistake and now will implement in small chunks one thing at a time
#214

@Zahid92 Zahid92 changed the title String based api support feat: String based api support Feb 28, 2024
Copy link

codecov bot commented Feb 28, 2024

Codecov Report

Attention: Patch coverage is 52.70270% with 35 lines in your changes are missing coverage. Please review.

Project coverage is 58.65%. Comparing base (f45d418) to head (5f7cd77).
Report is 85 commits behind head on main.

Files Patch % Lines
...wdin.Api/Distributions/DistributionsApiExecutor.cs 33.34% 10 Missing ⚠️
...c/Crowdin.Api/ProjectsGroups/FileFormatSettings.cs 0.00% 8 Missing ⚠️
src/Crowdin.Api/Clients/ClientsApiExecutor.cs 66.67% 5 Missing ⚠️
...pi/Distributions/DistributionStringBasedRelease.cs 0.00% 5 Missing ⚠️
.../Crowdin.Api/MachineTranslationEngines/MtEngine.cs 0.00% 5 Missing ⚠️
src/Crowdin.Api/Labels/Label.cs 0.00% 1 Missing ⚠️
src/Crowdin.Api/Labels/LabelsApiExecutor.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #224      +/-   ##
==========================================
+ Coverage   50.38%   58.65%   +8.27%     
==========================================
  Files         277      347      +70     
  Lines        3688     5368    +1680     
  Branches        0      435     +435     
==========================================
+ Hits         1858     3148    +1290     
- Misses       1830     2187     +357     
- Partials        0       33      +33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrii-bodnar andrii-bodnar linked an issue Feb 29, 2024 that may be closed by this pull request
14 tasks
@andrii-bodnar
Copy link
Member

@Zahid92 thank you! Please let me know when I can start reviewing this PR.

@Zahid92 Zahid92 marked this pull request as ready for review March 8, 2024 17:44
@Zahid92
Copy link
Contributor Author

Zahid92 commented Mar 9, 2024

Hi @andrii-bodnar, didn't get much time to work more onto this.
Could you review this much of work and once I get some time will continue with the rest of it.

@andrii-bodnar
Copy link
Member

andrii-bodnar commented Mar 11, 2024

@Zahid92 Thanks for letting me know!

Could you please summarize in the original issue what has been done and what still needs to be done?

@Zahid92
Copy link
Contributor Author

Zahid92 commented Mar 17, 2024

Hi @andrii-bodnar, here the list for whats done and whats remaining.

String based support for :

  • Clients API
  • Bundles
  • Distributions
  • Labels
  • Machine Translations

Remaining String based support for:

  • Notifications api
  • Projects api
  • Reports api
  • String translations api
  • Tasks api
  • Teams api
  • Translation memory api
  • Translation status api
  • Translations api
  • Users api
  • Vendors api
  • Webhooks api
  • Strings api

@andrii-bodnar
Copy link
Member

@Zahid92 thank you!

@andrii-bodnar andrii-bodnar mentioned this pull request Mar 18, 2024
14 tasks
@andrii-bodnar andrii-bodnar removed a link to an issue Mar 18, 2024
14 tasks
@andrii-bodnar andrii-bodnar changed the title feat: String based api support feat: String based api support (Clients, Bundles, Distributions, Labels, Machine Translations) Mar 18, 2024
@andrii-bodnar andrii-bodnar merged commit 373904a into crowdin:main Mar 25, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants