Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inaccurate node engine #7

Closed
gusvargas opened this issue Mar 23, 2021 · 2 comments
Closed

inaccurate node engine #7

gusvargas opened this issue Mar 23, 2021 · 2 comments

Comments

@gusvargas
Copy link

"engines": {
"node": ">=10.0.0"
},

But the build is emitting code like:

// dist/main.js
const ignoredElements = this.options.ignore?.concat(config_1.defaultIgnoreElements) ?? config_1.defaultIgnoreElements;

Which uses both optional chaining and nullish coalescing; features added in Node 14.

@nonara
Copy link
Collaborator

nonara commented Mar 23, 2021

Good catch! Thanks for pointing this out. I'll try to address this this week.

@nonara
Copy link
Collaborator

nonara commented Mar 28, 2021

Should be sorted now, @gusvargas. Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants