Add a function for checking keyboard enhancement support #732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 26, 2022
TimonPost
approved these changes
Dec 27, 2022
src/terminal/sys/unix.rs
Outdated
| // | ||
| // See <https://sw.kovidgoyal.net/kitty/keyboard-protocol/#detection-of-support-for-this-protocol> | ||
|
|
||
| let mut stdout = io::stdout(); |
There was a problem hiding this comment.
wonder if there are usecases when we need to read from an other file descriptor?
There was a problem hiding this comment.
Hmm I'm not sure. This function is mostly based on crossterm::cursor::sys::unix::read_position_raw which also uses io::stdout. Maybe it would be useful to pass in a file descriptor?
There was a problem hiding this comment.
For fetching the terminal size we use:
let file = File::open("/dev/tty").map(|file| (FileDesc::new(file.into_raw_fd(), true)));
let fd = if let Ok(file) = &file {
file.raw_fd()
} else {
// Fallback to libc::STDOUT_FILENO if /dev/tty is missing
STDOUT_FILENO
};
This is will try /dev/tty first, if not available it will fallback on standard output. It is a bit less restrictive
TimonPost
reviewed
Jan 8, 2023
src/terminal/sys/unix.rs
Outdated
| // | ||
| // See <https://sw.kovidgoyal.net/kitty/keyboard-protocol/#detection-of-support-for-this-protocol> | ||
|
|
||
| let mut stdout = io::stdout(); |
There was a problem hiding this comment.
For fetching the terminal size we use:
let file = File::open("/dev/tty").map(|file| (FileDesc::new(file.into_raw_fd(), true)));
let fd = if let Ok(file) = &file {
file.raw_fd()
} else {
// Fallback to libc::STDOUT_FILENO if /dev/tty is missing
STDOUT_FILENO
};
This is will try /dev/tty first, if not available it will fallback on standard output. It is a bit less restrictive
the-mikedavis
force-pushed
the
md-query-keyboard-enhancement
branch
from
7f1c780 to
47f4b5b
Compare
This follows the Kitty documentation's recommended way to check for progressive keyboard enhancement: query the flags and then query the primary device attributes (which is broadly supported). If we receive only the device attributes, the protocol is not supported.
the-mikedavis
force-pushed
the
md-query-keyboard-enhancement
branch
from
47f4b5b to
3570239
Compare
TimonPost
approved these changes
Jan 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows the Kitty documentation's recommended way to check for progressive keyboard enhancement: query the flags and then query the primary device attributes (which is broadly supported). If we receive the response to the flags query, we return the flags. Otherwise, the terminal must not support progressive keyboard enhancement.
Closes #717