Use io::Error for public error type #553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I agree, the error types we have currently do not really add that much value. Thanks for the pull request. Give it a look in a bit. |
TimonPost
approved these changes
Apr 13, 2021
yykamei
added a commit
to yykamei/thwack
that referenced
this pull request
Jun 20, 2021
Summary: Bump crossterm from 0.19.0 to 0.20.0. This requires extra work to remove `impl From<crossterm::ErrorKind> for Error` because `crossterm::ErrorKind` became just an alias of `io::Error`. We don't have to convert crossterm specific errors. See crossterm-rs/crossterm#553 for more details. Release note: https://github.com/crossterm-rs/crossterm/releases Changelog: https://github.com/crossterm-rs/crossterm/blob/master/CHANGELOG.md
yykamei
added a commit
to yykamei/thwack
that referenced
this pull request
Jun 20, 2021
Summary: Bump crossterm from 0.19.0 to 0.20.0. This requires extra work to remove `impl From<crossterm::ErrorKind> for Error` because `crossterm::ErrorKind` became just an alias of `io::Error`. We don't have to convert crossterm specific errors. See crossterm-rs/crossterm#553 for more details. Release note: https://github.com/crossterm-rs/crossterm/releases Changelog: https://github.com/crossterm-rs/crossterm/blob/master/CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes interoperation with the standard library much easier for users, which is especially useful given crossterm's low level APIs.
A custom error type is only useful if the context it provides outweighs its ergonomic burden, and in this case only the
ResizingTerminalFailureandSettingTerminalTitleFailurevariants were being used.Do we have examples of these variants being used in dependent code? I can add them to the new representation if so.