Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Typography system with dynamic font-family #3

Merged
merged 1 commit into from
Jan 18, 2025

Conversation

hyochan
Copy link
Member

@hyochan hyochan commented Jan 18, 2025

Description

Enhanced the typography system to support dynamic font families based on weights (normal, thin, bold). The setFontFamily function now updates font configurations globally, and getFontFamilies dynamically applies these settings to all typography components (Title, Heading1, Body1, etc.). Default font families (Pretendard) ensure backward compatibility while allowing seamless customization.

Test Plan

setFontFamily({
  normal: 'NotoSans-Regular',
  thin: 'NotoSans-Thin',
  bold: 'NotoSans-Bold',
});
<Typography.Title>Bold Title</Typography.Title>
<Typography.Body1>Normal Body Text</Typography.Body1>

Related Issues

N/A

Tests

N/A

Checklist

Before you create this PR confirms that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • Run yarn test:all and make sure nothing fails.
  • I am willing to follow-up on review comments in a timely manner.

@hyochan hyochan added the 🎯 feature New feature label Jan 18, 2025
@hyochan hyochan changed the title Enhance Typography System with Dynamic Font Family Support Enhance Typography system with dynamic font-family Jan 18, 2025
Copy link

Visit the preview URL for this PR (updated for commit f2cba46):

https://cpk-ui--pr3-feat-set-custom-font-r04p4rmf.web.app

(expires Sat, 25 Jan 2025 15:37:58 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 05244aa8e2a82af676f8a528c78a4bcd59756f99

@hyochan hyochan merged commit f02b805 into main Jan 18, 2025
3 checks passed
@hyochan hyochan deleted the feat/set-custom-fonts branch January 18, 2025 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎯 feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant