This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Pass maximum concurrent reconciles options to generated controllers #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alper Rifat Ulucinar <[email protected]>
Signed-off-by: Alper Rifat Ulucinar <[email protected]>
3 tasks
muvaf
approved these changes
Sep 17, 2021
muvaf
suggested changes
Sep 17, 2021
muvaf
approved these changes
Sep 17, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR proposes a change in terrajet that allows terrajet-based providers to set the maximum concurrent reconciles options for their controllers. The default value stays unmodified at 1.
It also contains a fix for
tfcli, where we now consume a store file if the pipeline had a chance to generate it before timing out.I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
Manually tested this in the scope of the scalability tests I'm running with #55. I will provide more context and a detailed discussion there for the motivation behind this PR.