Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug causing status to be cleared after adding Finalizer #804

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

gravufo
Copy link

@gravufo gravufo commented Jan 17, 2025

Description of your changes

This PR will fix the issue where the status sub-object would be cleared when adding the Finalizer. This would cause Observe-only resources to wait until the next SyncPeriod/PollPeriod to become Ready=true even though it should have been set at the first loop.

Fixes #791

Note: I am really unsure if these are the right places to do those changes, so please don't hesitate to leave comments pointing to the right locations.

I have:

  • Read and followed Crossplane's [contribution process].
  • Run earthly +reviewable to ensure this PR is ready for review.
  • Added or updated unit tests.
  • Linked a PR or a [docs tracking issue] to [document this change].
  • Added backport release-x.y labels to auto-backport this PR.

@gravufo gravufo requested a review from a team as a code owner January 17, 2025 22:14
@gravufo gravufo requested a review from turkenh January 17, 2025 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AddFinalizer clears Status subobject leading to delayed object readiness
1 participant