-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change logs support to track all changes being made to managed resources #754
Conversation
Pushed 2dd9458 to address all the protobuf linter errors found in https://github.com/crossplane/crossplane-runtime/actions/runs/10229176882/job/28302502501?pr=754. Looks like all those are green now in https://github.com/crossplane/crossplane-runtime/actions/runs/10257477240/job/28378586893?pr=754 🟢 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few last small nits, but this looks great to me. Thanks @jbw976!
@negz I've got all of your feedback integrated now, thanks for the awesome reviews dude! 😎 Pay special attention to #754 (comment) (using I've pushed all changes to my
Testing instructions and published images are also up to date in https://github.com/jbw976/change-log-sidecar/blob/main/README.md. Let me know if there's anything else I can improve with this PR! 🙇♂️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jbw976! One final thing I forgot, but otherwise this looks good. Feel free to squash and merge once you've added the timestamp.
Awesome, 0 unresolved conversations! I will likely squash/merge this today after a bit more testing 😎 |
Signed-off-by: Jared Watts <[email protected]>
…esources Signed-off-by: Jared Watts <[email protected]>
Signed-off-by: Jared Watts <[email protected]>
Description of your changes
This PR contains the
crossplane-runtime
changes to support cloud change logs.Further PRs for changes to the providers themselves (to consume these runtime changes) and for the change logs sidecar container are coming soon, but should not block this PR from being merged. Previews of those changes can be found in:
Testing
I have prepared some testing instructions at https://github.com/jbw976/change-log-sidecar/blob/main/README.md that reviewers can try out fairly easily on their local laptops.
Here is some example output that demonstrates what a subset of fields of a change log entry looks like, for example when an object is created, updated, then deleted:
A full change log entry looks like the below:
I have:
earthly +reviewable
to ensure this PR is ready for review.Addedbackport release-x.y
labels to auto-backport this PR.Need help with this checklist? See the cheat sheet.