managed reconciler: set deleting and creating conditions before calling respective functions #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng respective external functions Signed-off-by: Muvaffak Onus <[email protected]>
|
I think originally the idea behind letting the ExternalClients handle this was because I speculated that concepts like "deleting" and "creating" might have different names for some resources (e.g. "provisioning"). In practice that hasn't really been the case so this seems reasonable. |
negz
approved these changes
Feb 11, 2021
hasheddan
approved these changes
Feb 11, 2021
2 tasks
2 tasks
This was referenced Sep 21, 2021
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
We set these conditions in
ExternalClientimplementations but they are easy to forget and there isn't a scenario I can think of that we'd not want to set them.I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Unit tests.