Bump Terraform provider version to v5.73.0 #1547
Conversation
|
/test-examples="examples/mq/v1alpha1/user.yaml" |
turkenf
force-pushed
the
bump-tf-5.73.0
branch
from
3a121b5
to
50d5cb2
Compare
|
/test-examples="examples/mq/v1alpha1/user.yaml" |
|
/test-examples="examples/ec2/v1beta2/vpcendpoint.yaml" |
turkenf
force-pushed
the
bump-tf-5.73.0
branch
from
f9c844f
to
6a0e2d5
Compare
|
/test-examples="examples/ec2/v1beta2/vpcendpoint.yaml" |
|
/test-examples="examples/mq/v1alpha1/user.yaml" |
|
/test-examples="examples/ec2/v1beta2/vpcendpoint.yaml" |
|
/test-examples="examples/backup/v1beta2/plan.yaml" |
|
/test-examples="examples/deploy/v1beta1/deploymentconfig.yaml" |
|
/test-examples="examples/dynamodb/v1beta1/table.yaml" |
|
/test-examples="examples/elbv2/v1beta2/lblistener-forward-multiple-targetgroups.yaml" |
|
/test-examples="examples/firehose/v1beta1/deliverystream.yaml" |
|
/test-examples="examples/s3/v1beta1/bucket.yaml" |
|
/test-examples="examples/sagemaker/v1beta1/userprofile.yaml" |
| @@ -85,7 +85,7 @@ type CognitoMemberDefinitionParameters struct { | |||
|
|
|||
| // An identifier for a user group. | |||
| // +crossplane:generate:reference:type=github.com/upbound/provider-aws/apis/cognitoidp/v1beta1.UserGroup | |||
| // +crossplane:generate:reference:extractor=github.com/crossplane/upjet/pkg/resource.ExtractResourceID() | |||
| // +crossplane:generate:reference:extractor=github.com/crossplane/upjet/pkg/resource.ExtractParamPath("name",false) | |||
There was a problem hiding this comment.
Thanks for backporting the new fields, @mergenci; your tool seems to have done a good job 🙌
I think we should just backport the comments line (code generation directives) changes in this file, I remember we talked about this. We can add these manually for now, but it would be good if the tool could handle these in the future 🙂
There was a problem hiding this comment.
Then let's attempt automating backporting of comments in the next Terraform provider bump. Thanks for the catch @turkenf. I backported documentation comments in addition to the directives you suggested. Please check 🙏
turkenf
force-pushed
the
bump-tf-5.73.0
branch
from
71e112b
to
2eb7251
Compare
|
/test-examples="examples/ec2/v1beta2/vpcendpoint.yaml" |
|
/test-examples="examples/s3/v1beta1/bucket.yaml" |
turkenf
requested review from
ulucinar,
sergenyalcin and
mbbush
as code owners
|
/test-examples="examples/ec2/v1beta2/vpcendpoint.yaml" |
Signed-off-by: Fatih Türken <[email protected]>
Signed-off-by: Fatih Türken <[email protected]>
Signed-off-by: Fatih Türken <[email protected]>
Signed-off-by: Cem Mergenci <[email protected]>
Signed-off-by: Cem Mergenci <[email protected]>
Note that this is neither an exhaustive list of which comments to backport nor how to backport them. Signed-off-by: Cem Mergenci <[email protected]>
Signed-off-by: Cem Mergenci <[email protected]>
Temporarily, UPTEST_LOCAL_VERSION takes effect instead of UPTEST_VERSION. We noticed that it was the case after bumping it. Now, we revert. Signed-off-by: Cem Mergenci <[email protected]>
turkenf
force-pushed
the
bump-tf-5.73.0
branch
from
38525f8
to
5a1269f
Compare
|
/test-examples="examples/ec2/v1beta2/vpcendpoint.yaml" |
|
/test-examples="examples/s3/v1beta1/bucket.yaml" |
Description of your changes
This PR bumps native tf provider version to
v5.73.0I have:
make reviewableto ensure this PR is ready for review.Addedbackport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
Uptest runs:
examples/backup/v1beta2/plan.yaml=> https://github.com/crossplane-contrib/provider-upjet-aws/actions/runs/11632512983examples/deploy/v1beta1/deploymentconfig.yaml=> https://github.com/crossplane-contrib/provider-upjet-aws/actions/runs/11632528153examples/dynamodb/v1beta1/table.yaml=> https://github.com/crossplane-contrib/provider-upjet-aws/actions/runs/11632535977examples/ec2/v1beta2/vpcendpoint.yaml=> https://github.com/crossplane-contrib/provider-upjet-aws/actions/runs/11631733329examples/elbv2/v1beta2/lblistener-forward-multiple-targetgroups.yaml=> https://github.com/crossplane-contrib/provider-upjet-aws/actions/runs/11632562922examples/firehose/v1beta1/deliverystream.yaml=> https://github.com/crossplane-contrib/provider-upjet-aws/actions/runs/11632582297examples/mq/v1alpha1/user.yaml=> https://github.com/crossplane-contrib/provider-upjet-aws/actions/runs/11631731126examples/s3/v1beta1/bucket.yaml=> https://github.com/crossplane-contrib/provider-upjet-aws/actions/runs/11632590414examples/sagemaker/v1beta1/userprofile.yaml=> https://github.com/crossplane-contrib/provider-upjet-aws/actions/runs/11632610372