Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Move to CLI schema #49

Merged
merged 2 commits into from
Mar 16, 2022

Conversation

ezgidemirel
Copy link
Collaborator

@ezgidemirel ezgidemirel commented Mar 11, 2022

Description of your changes

This change updates the provider to use CLI schema.

Fixes #42

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

I created/deleted SQL DB instance, SQL DB, GKE cluster resources.


NAME                                                       READY   SYNCED   EXTERNAL-NAME      AGE
cluster.container.gcp.jet.crossplane.io/ezgi-gke-cluster   True    True    ezgi-gke-cluster   24m

NAME                                                       READY   SYNCED   EXTERNAL-NAME   AGE
databaseinstance.sql.gcp.jet.crossplane.io/ezgi-instance   True    True     ezgi-instance   61m

NAME                                               READY   SYNCED   EXTERNAL-NAME   AGE
database.sql.gcp.jet.crossplane.io/ezgi-database   True    True     ezgi-database   26m

@ezgidemirel ezgidemirel reopened this Mar 11, 2022
@ezgidemirel ezgidemirel force-pushed the move-to-cli-schema branch 2 times, most recently from 947688d to 8a79c14 Compare March 11, 2022 11:17
@ezgidemirel
Copy link
Collaborator Author

@turkenh PR is ready for review :)

@ezgidemirel ezgidemirel requested review from turkenh and muvaf March 11, 2022 16:29
Copy link
Collaborator

@turkenh turkenh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great except for one typo!
Feel free to merge it once you fixed it.

cmd/provider/main.go Outdated Show resolved Hide resolved
Signed-off-by: ezgidemirel <[email protected]>
@ezgidemirel ezgidemirel reopened this Mar 16, 2022
@ezgidemirel ezgidemirel merged commit ab913f4 into crossplane-contrib:main Mar 16, 2022
@ezgidemirel ezgidemirel deleted the move-to-cli-schema branch March 16, 2022 15:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to use CLI schema
2 participants