This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Fix wrong external name configuration of azurerm_cosmosdb_account #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sergen Yalçın <[email protected]>
ulucinar
approved these changes
Mar 15, 2022
There was a problem hiding this comment.
LGTM, thank you @sergenyalcin. Thank you also for the example provided & tested!
ulucinar
reviewed
Mar 15, 2022
| geoLocation: | ||
| - failoverPriority: 0 | ||
| location: "East US" | ||
| zoneRedundant: False |
There was a problem hiding this comment.
Btw, what happens if we omit this?
There was a problem hiding this comment.
For the zoneRedundant field, the default value is also False and when we omit this, the value is set to the False
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #157
This PR fixes the wrong external name configuration of
azurerm_cosmosdb_accountand adds an example manifest.I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
This PR tested by using the new example manifest.