This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Move control variables to the main Makefile #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Move TERRAFORM_* to the main Makefile and export them * Deprecate `AZURERM_REFSPEC` to avoid duplication and cross reference Signed-off-by: Yury Tsarev <[email protected]>
ezgidemirel
approved these changes
Mar 8, 2022
There was a problem hiding this comment.
I've created another PR on top of this and tested with creating some resources on Azure side. All looks good to me. Thanks @ytsarev !
ulucinar
approved these changes
Mar 11, 2022
|
Thank you @ytsarev, lgtm. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
AZURERM_REFSPECto avoid duplication and cross referenceI have:
make reviewable testto ensure this PR is ready for review.How has this code been tested