This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
generated from crossplane/provider-template
-
Notifications
You must be signed in to change notification settings - Fork 20
Promote IOTHubEndpointStorageContainer and IOTHubFallbackRoute to v1alpha2 #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulucinar
suggested changes
Feb 28, 2022
@ulucinar thanks a lot for the suggestion, it worked! Please review again |
Signed-off-by: Yury Tsarev <[email protected]>
Signed-off-by: Yury Tsarev <[email protected]>
Signed-off-by: Yury Tsarev <[email protected]>
@ulucinar rebased, thanks! |
ulucinar
reviewed
Feb 28, 2022
|
||
// +crossplane:generate:reference:type=IOTHub | ||
// +kubebuilder:validation:Optional | ||
IOTHubName *string `json:"iothubName,omitempty" tf:"iothub_name,omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's interesting that we have generated this field's serialized name as iothubName
but the corresponding ref field's and selector field's serialized names as iotHubNameRef
and iotHubNameSelector
, respectively.
ulucinar
approved these changes
Mar 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @ytsarev, very much appreciated :)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR promotes IOTHubFallbackRoute and its dependency of IOTHubEndpointStorageContainer to v1alpha2
Caveats:
FallbackRoute/default
externalName/id as it is always the same according to#149 should be merged first
I have:
make reviewable test
to ensure this PR is ready for review.How has this code been tested