Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Promote IOTHubEndpointStorageContainer and IOTHubFallbackRoute to v1alpha2 #150

Merged
merged 3 commits into from
Mar 1, 2022

Conversation

ytsarev
Copy link
Collaborator

@ytsarev ytsarev commented Feb 28, 2022

Description of your changes

This PR promotes IOTHubFallbackRoute and its dependency of IOTHubEndpointStorageContainer to v1alpha2

Caveats:

  • Special handling of FallbackRoute/default externalName/id as it is always the same according to

#149 should be merged first

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

k apply -f examples/devices/iothubendpointstoragecontainer.yaml
k get iothubendpointstoragecontainer.devices.azure.jet.crossplane.io/yury-example
NAME           READY   SYNCED   EXTERNAL-NAME   AGE
yury-example   True    True     yury-example    34h
k apply -f examples/devices/iothubfallbackroute.yaml 
NAME           READY   SYNCED   EXTERNAL-NAME   AGE
yury-example   True    True     default         58m

@ytsarev ytsarev requested a review from ulucinar February 28, 2022 11:04
config/devices/config.go Outdated Show resolved Hide resolved
config/common/common.go Outdated Show resolved Hide resolved
@ytsarev
Copy link
Collaborator Author

ytsarev commented Feb 28, 2022

@ulucinar thanks a lot for the suggestion, it worked! Please review again

@ulucinar
Copy link
Collaborator

@ulucinar thanks a lot for the suggestion, it worked! Please review again

Hi @ytsarev,
Sure thing! I've merged the parent PR. Could you please rebase this PR?

@ytsarev
Copy link
Collaborator Author

ytsarev commented Feb 28, 2022

@ulucinar rebased, thanks!

config/devices/config.go Show resolved Hide resolved

// +crossplane:generate:reference:type=IOTHub
// +kubebuilder:validation:Optional
IOTHubName *string `json:"iothubName,omitempty" tf:"iothub_name,omitempty"`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's interesting that we have generated this field's serialized name as iothubName but the corresponding ref field's and selector field's serialized names as iotHubNameRef and iotHubNameSelector, respectively.

@ytsarev ytsarev requested a review from ulucinar March 1, 2022 09:07
Copy link
Collaborator

@ulucinar ulucinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ytsarev, very much appreciated :)

@ulucinar ulucinar merged commit 461d6a3 into crossplane-contrib:main Mar 1, 2022
@ytsarev ytsarev deleted the iothub branch March 1, 2022 10:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants