This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Fix external name configurations of storage_container and storage_blob resources
#135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…b resources Signed-off-by: Sergen Yalçın <[email protected]>
sergenyalcin
changed the title
storage_container and storage_blob resourcesstorage_container and storage_blob resources
ulucinar
approved these changes
Jan 28, 2022
| return strings.TrimPrefix(idStr, "https://"), nil | ||
| } | ||
| // https://storacc.blob.core.windows.net/container/blob.vhd | ||
| r.ExternalName.GetExternalNameFn = common.GetResourceNameFromIDURLFn(1) |
This was referenced Jan 28, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #129
This PR resolves the configuration issues for the two resources.
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
The external resources were provisioned by using the example manifests. Also the update and delete operations were tested.