This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Exclude "spec.forProvider.privateLinkEnabled" from late-initialization #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #106
This PR proposes a change to exclude
spec.forProvider.privateLinkEnabledfrom late-initialization because when thespec.forProvider.privateClusterEnabledis set, these two options conflict with each other and the Terraform resource documentation does not mention about theprivate_link_enabledargument.I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Modified the example manifest provided in the repo for
KubernetesClusterto include aspec.forProvider.privateClusterEnabledand provisioned an AKS cluster using it. After the cluster was successfully provisioned and the provider completed late-initialization, the resource was still in synced state.