Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add a note on external-name annotation on bucket #387

Merged
merged 1 commit into from
Oct 6, 2021

Conversation

terrytangyuan
Copy link
Contributor

@terrytangyuan terrytangyuan commented Oct 6, 2021

I stumbled upon this issue and it took my a while to figure out how the resolve the permission issue as the error is not very informative and actually misleading. Adding this note would help new users who might struggle with this as well.

I was having trouble creating a bucket that requires storage.buckets.get access to the Google Cloud Storage bucket while my SA has roles/storage.admin already (see below for more info).

managed/bucket.storage.gcp.crossplane.io cannot get GCP bucket attributes: googleapi: Error 403: [email protected] does not have storage.buckets.get access to the Google Cloud Storage bucket., forbidden
gcloud projects add-iam-policy-binding --role=roles/storage.admin a-test --member "serviceAccount:[email protected]"

Signed-off-by: Yuan Tang [email protected]

Description of your changes

Fixes #

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Copy link
Collaborator

@Feggah Feggah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for my last comment, I think I've misread your issue. It wasn't about what the annotations does, it was actually about the uniqueness of the resource name, right? Then I agree with you 👍🏼 LGTM!

Copy link
Contributor

@turkenh turkenh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @terrytangyuan!

@turkenh turkenh merged commit 43125ff into crossplane-contrib:master Oct 6, 2021
@terrytangyuan terrytangyuan deleted the note-on-bucket branch October 6, 2021 12:04
@Feggah Feggah mentioned this pull request Oct 14, 2021
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants