Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump crossplane-runtime #372

Merged
merged 3 commits into from
Sep 15, 2021
Merged

Bump crossplane-runtime #372

merged 3 commits into from
Sep 15, 2021

Conversation

negz
Copy link
Member

@negz negz commented Sep 15, 2021

Description of your changes

Plus a few small updates (e.g. build submodule, errors package). See each commit message for context.

My primary motivation here is getting provider-gcp to the 'latest and greatest' reconcile logic so I can use that when scale testing per https://github.com/negz/crossplane-scale.

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Just make reviewable, which seems appropriate for dependency updates. We're using this runtime build already elsewhere (e.g. provider-aws).

Copy link
Member

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@negz LGTM -- we may want to pin to a crossplane-runtime version for impending provider-gcp release, but I'll defer to @turkenh 👍🏻

@negz negz merged commit 469c003 into crossplane-contrib:master Sep 15, 2021
@negz negz deleted the bumpity branch September 15, 2021 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants