Skip to content
This repository has been archived by the owner on Dec 24, 2019. It is now read-only.

clarify factoids metrics and values #148

Open
mhow2 opened this issue Mar 19, 2019 · 5 comments
Open

clarify factoids metrics and values #148

mhow2 opened this issue Mar 19, 2019 · 5 comments
Assignees

Comments

@mhow2
Copy link

mhow2 commented Mar 19, 2019

I have started to have a closer look to factoids in SCAVA:

Can we please clarify the following:

  • not all summary on /factoids are documented
  • it looks to me that not all factoids can provide a STAR score. For example org.eclipse.scava.factoid.bugs.weekly.BugsChannelWeeklyFactoid which tells "The busiest day of the week is Sunday (14.29% of reports and comments), while the least busy day is Sunday (14.29%) (Monday: 14.29%, Tuesday: 14.29%, Wednesday: 14.29%, Thursday: 14.29%, Friday: 14.29%, Saturday: 14.29%).\n" , has stars : FOUR. Taking aside that the values looks wrong, I don't understand how we can express this kind of facts with stars in the end.
  • For some of the facts it's not always clear to me what to conclude from the STARS score. Is it good or bad, etc.
  • Some of the fact's (on /f) text mention strange chars like (� %)
  • We don't have much info about the time period that has been considered for compute the facts. It's based on the whole available data I suppose.
  • There are factoids with null value
@creat89
Copy link
Contributor

creat89 commented Mar 25, 2019

Some factoid metrics should have been improved with commit b243dd5. However, we will check some of those that are related to our deliverables.

@Danny2097
Copy link
Member

Danny2097 commented Mar 25, 2019

@mhow2

Not all summary on /factoids are documented

Thank you for brining the documentation issue to us. The factoids were directly ported to Scava from OSSMETER. We will update these as soon as we can.

It looks to me that not all factoids can provide a STAR score....

I would suggest that you raise this during the meeting in Paris. Perhaps Davide or Yannis maybe able to justify the reasoning behind this decision to implement the star rating in OSSMETER.

For some of the facts it's not always clear to me what to conclude from the STARS score. Is it good or bad, etc.

With regards to the number of stars, I believe the higher number of 'STARS' relates to a more positive outcome. Again this is based on reading the code, I would suggest to also raise this is Paris.

Some of the fact's (on /f) text mention strange chars like (� %)

Regarding the strange character you are witnessing are related to an error in the calculations ported from OSSMETER. Essentially, the current code does not prevent the calculation from dividing by 0. Since the code converts from a float to a String the character (which refers to NaN) is returned. We will correct the instances of this happening in factoids relating to our WP.

We don't have much info about the time period that has been considered for compute the facts. It's based on the whole available data I suppose.

You are correct. Currently, Scava requires the user to specify the date range for analysis for a project, either through a fixed date analysis (were a user specifies a start and end date for analysis) or via a daily analysis (were the user only specifies a start date). I know the information to calculate, let's say the number of days of analysis, can be calculated from information within the database. However, I am unsure to whom is responsible for making this visible to an end user. I agree with you that this information is vital when interpreting the factoids.

There are factoids with null value.

Looking at the information you provided to us, the factoids that are returning null I believe that are related to CWI's WP. @tdegueul should be able to help clear this up.

creat89 added a commit that referenced this issue Mar 26, 2019
This commit solves somme issues indicated in issue #148
@creat89 creat89 assigned nnamokon and unassigned creat89 Apr 30, 2019
@Danny2097 Danny2097 removed their assignment Jul 8, 2019
@mhow2
Copy link
Author

mhow2 commented Sep 10, 2019

We need to do a check pass on factoids accuracy and the question raised in this issue. Who can help ?

@creat89
Copy link
Contributor

creat89 commented Sep 10, 2019

@mhow2, I'll discuss this with @nnamokon tomorrow

@creat89
Copy link
Contributor

creat89 commented Sep 11, 2019

Hello @mhow2,

First of all, it seems that at a the day you raised the bug, I didn't understand correctly that there was an issue with the weekly factoid. Now, I have checked and yes, there was an issue with but with the transient metric that was charged of calculating the percentage of comments per day. In this case, the error is that it was setting a percentage of 14.29 when the days did not have any comments. This issue was happening with its similar version but of newsgroups. I have pushed the changes in 3a95498. However, it might be too late for projects that have been already analyzed.

Concerning with the documentation of factoids. This will be done by @nnamokon, he will explain which are the reasons or the the ranges to give specific stars to the projects.

With respect to the factoids that are null, those seem to be related to Rascal, thus @tdegueul should be able to fix the missing factoid field.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants